Commit c80151ec authored by LABBE Corentin's avatar LABBE Corentin Committed by David S. Miller
Browse files

net: stmmac: invert the logic for dumping regs 



It is easier to follow the logic by removing the not operator

Signed-off-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: default avatarGiuseppe Cavallaro <peppe.cavallaro@st.com>
Reviewed-by: default avatarGiuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cc26dc67

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

+9 −9
Original line number Diff line number Diff line
@@ -442,24 +442,24 @@ static void stmmac_ethtool_gregs(struct net_device *dev, 


	memset(reg_space, 0x0, REG_SPACE_SIZE);



	if (!(priv->plat->has_gmac || priv->plat->has_gmac4)) {

	if (priv->plat->has_gmac || priv->plat->has_gmac4) {

		/* MAC registers */

		for (i = 0; i < 12; i++)

		for (i = 0; i < 55; i++)

			reg_space[i] = readl(priv->ioaddr + (i * 4));

		/* DMA registers */

		for (i = 0; i < 9; i++)

			reg_space[i + 12] =

		for (i = 0; i < 22; i++)

			reg_space[i + 55] =

			    readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));

		reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);

		reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);

	} else {

		/* MAC registers */

		for (i = 0; i < 55; i++)

		for (i = 0; i < 12; i++)

			reg_space[i] = readl(priv->ioaddr + (i * 4));

		/* DMA registers */

		for (i = 0; i < 22; i++)

			reg_space[i + 55] =

		for (i = 0; i < 9; i++)

			reg_space[i + 12] =

			    readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));

		reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);

		reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE