Commit c7ed6d01 authored Sep 27, 2019 by Navid Emamdoost Committed by Saeed Mahameed Oct 18, 2019

net/mlx5: fix memory leak in mlx5_fw_fatal_reporter_dump



In mlx5_fw_fatal_reporter_dump if mlx5_crdump_collect fails the
allocated memory for cr_data must be released otherwise there will be
memory leak. To fix this, this commit changes the return instruction
into goto error handling.

Fixes: 9b1f2982 ("net/mlx5: Add support for FW fatal reporter dump")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent c8c2a057

drivers/net/ethernet/mellanox/mlx5/core/health.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -572,7 +572,7 @@ mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter,
		return -ENOMEM;
		err = mlx5_crdump_collect(dev, cr_data);
		if (err)
		return err;
		goto free_data;

		if (priv_ctx) {
		struct mlx5_fw_reporter_ctx *fw_reporter_ctx = priv_ctx;

Admin message