Commit c7da6fa4 authored by Pavel Fedin's avatar Pavel Fedin Committed by Marc Zyngier
Browse files

arm/arm64: KVM: Detect vGIC presence at runtime 



Before commit 662d9715
("arm/arm64: KVM: Kill CONFIG_KVM_ARM_{VGIC,TIMER}") is was possible to
compile the kernel without vGIC and vTimer support. Commit message says
about possibility to detect vGIC support in runtime, but this has never
been implemented.

This patch introduces runtime check, restoring the lost functionality.
It again allows to use KVM on hardware without vGIC. Interrupt
controller has to be emulated in userspace in this case.

-ENODEV return code from probe function means there's no GIC at all.
-ENXIO happens when, for example, there is GIC node in the device tree,
but it does not specify vGIC resources. Any other error code is still
treated as full stop because it might mean some really serious problems.

Signed-off-by: default avatarPavel Fedin <p.fedin@samsung.com>
Reviewed-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 1b1ebe82

arch/arm/kvm/arm.c

+20 −2
Original line number Diff line number Diff line
@@ -63,6 +63,8 @@ static u32 kvm_next_vmid; 
static unsigned int kvm_vmid_bits __read_mostly;

static DEFINE_SPINLOCK(kvm_vmid_lock);



static bool vgic_present;



static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu)

{

	BUG_ON(preemptible());
@@ -134,7 +136,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) 
	kvm->arch.vmid_gen = 0;



	/* The maximum number of VCPUs is limited by the host's GIC model */

	kvm->arch.max_vcpus = kvm_vgic_get_max_vcpus();

	kvm->arch.max_vcpus = vgic_present ?

				kvm_vgic_get_max_vcpus() : KVM_MAX_VCPUS;



	return ret;

out_free_stage2_pgd:
@@ -174,6 +177,8 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) 
	int r;

	switch (ext) {

	case KVM_CAP_IRQCHIP:

		r = vgic_present;

		break;

	case KVM_CAP_IOEVENTFD:

	case KVM_CAP_DEVICE_CTRL:

	case KVM_CAP_USER_MEMORY:
@@ -917,6 +922,8 @@ static int kvm_vm_ioctl_set_device_addr(struct kvm *kvm, 


	switch (dev_id) {

	case KVM_ARM_DEVICE_VGIC_V2:

		if (!vgic_present)

			return -ENXIO;

		return kvm_vgic_addr(kvm, type, &dev_addr->addr, true);

	default:

		return -ENODEV;
@@ -931,6 +938,8 @@ long kvm_arch_vm_ioctl(struct file *filp, 


	switch (ioctl) {

	case KVM_CREATE_IRQCHIP: {

		if (!vgic_present)

			return -ENXIO;

		return kvm_vgic_create(kvm, KVM_DEV_TYPE_ARM_VGIC_V2);

	}

	case KVM_ARM_SET_DEVICE_ADDR: {
@@ -1121,8 +1130,17 @@ static int init_hyp_mode(void) 
	 * Init HYP view of VGIC

	 */

	err = kvm_vgic_hyp_init();

	if (err)

	switch (err) {

	case 0:

		vgic_present = true;

		break;

	case -ENODEV:

	case -ENXIO:

		vgic_present = false;

		break;

	default:

		goto out_free_context;

	}



	/*

	 * Init HYP architected timer support

CRA Git | Maintained and supported by SUSTech CRA and CCSE