Commit c7d5f6db authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: pcf8563: remove useless indirection 

pcf8563_rtc_read_time and pcf8563_set_datetime are only used after casting
dev to an i2c_client. Remove that useless indirection.

Link: https://lore.kernel.org/r/20190829212547.19185-4-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 8d3f805e

drivers/rtc/rtc-pcf8563.c

+6 −14
Original line number Diff line number Diff line
@@ -196,8 +196,9 @@ static irqreturn_t pcf8563_irq(int irq, void *dev_id) 
 * In the routines that deal directly with the pcf8563 hardware, we use

 * rtc_time -- month 0-11, hour 0-23, yr = calendar year-epoch.

 */

static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)

static int pcf8563_rtc_read_time(struct device *dev, struct rtc_time *tm)

{

	struct i2c_client *client = to_i2c_client(dev);

	struct pcf8563 *pcf8563 = i2c_get_clientdata(client);

	unsigned char buf[9];

	int err;
@@ -244,8 +245,9 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm) 
	return 0;

}



static int pcf8563_set_datetime(struct i2c_client *client, struct rtc_time *tm)

static int pcf8563_rtc_set_time(struct device *dev, struct rtc_time *tm)

{

	struct i2c_client *client = to_i2c_client(dev);

	struct pcf8563 *pcf8563 = i2c_get_clientdata(client);

	unsigned char buf[9];
@@ -299,8 +301,8 @@ static int pcf8563_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long 
		 * because of the cached voltage_low value but do it

		 * anyway for consistency.

		 */

		if (pcf8563_get_datetime(to_i2c_client(dev), &tm))

			pcf8563_set_datetime(to_i2c_client(dev), &tm);

		if (pcf8563_rtc_read_time(dev, &tm))

			pcf8563_rtc_set_time(dev, &tm);



		/* Clear the cached value. */

		pcf8563->voltage_low = 0;
@@ -314,16 +316,6 @@ static int pcf8563_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long 
#define pcf8563_rtc_ioctl NULL

#endif



static int pcf8563_rtc_read_time(struct device *dev, struct rtc_time *tm)

{

	return pcf8563_get_datetime(to_i2c_client(dev), tm);

}



static int pcf8563_rtc_set_time(struct device *dev, struct rtc_time *tm)

{

	return pcf8563_set_datetime(to_i2c_client(dev), tm);

}



static int pcf8563_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *tm)

{

	struct i2c_client *client = to_i2c_client(dev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE