Commit c7cd7c74 authored Aug 08, 2019 by Wenwen Wang Committed by Takashi Iwai Aug 08, 2019

sound: fix a memory leak bug



In sound_insert_unit(), the controlling structure 's' is allocated through
kmalloc(). Then it is added to the sound driver list by invoking
__sound_insert_unit(). Later on, if __register_chrdev() fails, 's' is
removed from the list through __sound_remove_unit(). If 'index' is not less
than 0, -EBUSY is returned to indicate the error. However, 's' is not
deallocated on this execution path, leading to a memory leak bug.

To fix the above issue, free 's' before -EBUSY is returned.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent c02f77d3

sound/sound_core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -275,7 +275,8 @@ retry:
		goto retry;
		}
		spin_unlock(&sound_loader_lock);
		return -EBUSY;
		r = -EBUSY;
		goto fail;
		}
		}

Admin message