Commit c7ba65d7 authored by Florian Westphal's avatar Florian Westphal Committed by David S. Miller
Browse files

net: ip: push gso skb forwarding handling down the stack 



Doing the segmentation in the forward path has one major drawback:

When using virtio, we may process gso udp packets coming
from host network stack.  In that case, netfilter POSTROUTING
will see one packet with udp header followed by multiple ip
fragments.

Delay the segmentation and do it after POSTROUTING invocation
to avoid this.

Fixes: fe6cc55f ("net: ip, ipv6: handle gso skbs in forwarding path")
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 418a3156

net/ipv4/ip_forward.c

+0 −50
Original line number Diff line number Diff line
@@ -56,53 +56,6 @@ static bool ip_exceeds_mtu(const struct sk_buff *skb, unsigned int mtu) 
	return true;

}



static bool ip_gso_exceeds_dst_mtu(const struct sk_buff *skb)

{

	unsigned int mtu;



	if (skb->local_df || !skb_is_gso(skb))

		return false;



	mtu = ip_dst_mtu_maybe_forward(skb_dst(skb), true);



	/* if seglen > mtu, do software segmentation for IP fragmentation on

	 * output.  DF bit cannot be set since ip_forward would have sent

	 * icmp error.

	 */

	return skb_gso_network_seglen(skb) > mtu;

}



/* called if GSO skb needs to be fragmented on forward */

static int ip_forward_finish_gso(struct sk_buff *skb)

{

	struct dst_entry *dst = skb_dst(skb);

	netdev_features_t features;

	struct sk_buff *segs;

	int ret = 0;



	features = netif_skb_dev_features(skb, dst->dev);

	segs = skb_gso_segment(skb, features & ~NETIF_F_GSO_MASK);

	if (IS_ERR(segs)) {

		kfree_skb(skb);

		return -ENOMEM;

	}



	consume_skb(skb);



	do {

		struct sk_buff *nskb = segs->next;

		int err;



		segs->next = NULL;

		err = dst_output(segs);



		if (err && ret == 0)

			ret = err;

		segs = nskb;

	} while (segs);



	return ret;

}



static int ip_forward_finish(struct sk_buff *skb)

{
@@ -114,9 +67,6 @@ static int ip_forward_finish(struct sk_buff *skb) 
	if (unlikely(opt->optlen))

		ip_forward_options(skb);



	if (ip_gso_exceeds_dst_mtu(skb))

		return ip_forward_finish_gso(skb);



	return dst_output(skb);

}

net/ipv4/ip_output.c

+48 −3
Original line number Diff line number Diff line
@@ -211,6 +211,48 @@ static inline int ip_finish_output2(struct sk_buff *skb) 
	return -EINVAL;

}



static int ip_finish_output_gso(struct sk_buff *skb)

{

	netdev_features_t features;

	struct sk_buff *segs;

	int ret = 0;



	/* common case: locally created skb or seglen is <= mtu */

	if (((IPCB(skb)->flags & IPSKB_FORWARDED) == 0) ||

	      skb_gso_network_seglen(skb) <= ip_skb_dst_mtu(skb))

		return ip_finish_output2(skb);



	/* Slowpath -  GSO segment length is exceeding the dst MTU.

	 *

	 * This can happen in two cases:

	 * 1) TCP GRO packet, DF bit not set

	 * 2) skb arrived via virtio-net, we thus get TSO/GSO skbs directly

	 * from host network stack.

	 */

	features = netif_skb_features(skb);

	segs = skb_gso_segment(skb, features & ~NETIF_F_GSO_MASK);

	if (IS_ERR(segs)) {

		kfree_skb(skb);

		return -ENOMEM;

	}



	consume_skb(skb);



	do {

		struct sk_buff *nskb = segs->next;

		int err;



		segs->next = NULL;

		err = ip_fragment(segs, ip_finish_output2);



		if (err && ret == 0)

			ret = err;

		segs = nskb;

	} while (segs);



	return ret;

}



static int ip_finish_output(struct sk_buff *skb)

{

#if defined(CONFIG_NETFILTER) && defined(CONFIG_XFRM)
@@ -220,9 +262,12 @@ static int ip_finish_output(struct sk_buff *skb) 
		return dst_output(skb);

	}

#endif

	if (skb->len > ip_skb_dst_mtu(skb) && !skb_is_gso(skb))

	if (skb_is_gso(skb))

		return ip_finish_output_gso(skb);



	if (skb->len > ip_skb_dst_mtu(skb))

		return ip_fragment(skb, ip_finish_output2);

	else



	return ip_finish_output2(skb);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE