Commit c7ba50fe authored Jul 26, 2019 by Jia-Ju Bai Committed by David S. Miller Jul 27, 2019

net: rds: Fix possible null-pointer dereferences in rds_rdma_cm_event_handler_cmn()



In rds_rdma_cm_event_handler_cmn(), there are some if statements to
check whether conn is NULL, such as on lines 65, 96 and 112.
But conn is not checked before being used on line 108:
    trans->cm_connect_complete(conn, event);
and on lines 140-143:
    rdsdebug("DISCONNECT event - dropping connection "
            "%pI6c->%pI6c\n", &conn->c_laddr,
            &conn->c_faddr);
    rds_conn_drop(conn);

Thus, possible null-pointer dereferences may occur.

To fix these bugs, conn is checked before being used.

These bugs are found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a0d57a55

net/rds/rdma_transport.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -105,6 +105,7 @@ static int rds_rdma_cm_event_handler_cmn(struct rdma_cm_id *cm_id,
		break;

		case RDMA_CM_EVENT_ESTABLISHED:
		if (conn)
		trans->cm_connect_complete(conn, event);
		break;

		@@ -137,6 +138,8 @@ static int rds_rdma_cm_event_handler_cmn(struct rdma_cm_id *cm_id,
		break;

		case RDMA_CM_EVENT_DISCONNECTED:
		if (!conn)
		break;
		rdsdebug("DISCONNECT event - dropping connection "
		"%pI6c->%pI6c\n", &conn->c_laddr,
		&conn->c_faddr);

Admin message