Commit c7ac601e authored Aug 16, 2012 by H Hartley Sweeten Committed by Greg Kroah-Hartman Aug 17, 2012

staging: comedi: cb_pcimdda: fix bug in call to subdev_8255_cleanup



The attach function only allocated 2 subdevices, an analog output
sundevice (index 0) and the 8255 dio subdevice (index 1). The
detach function is passing the wrong subdevice (index 2) to the
subdev_8255_cleanup function which will result in a bug when
it tries to do the kfree(s->private).

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8496fc47

drivers/staging/comedi/drivers/cb_pcimdda.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -257,7 +257,7 @@ static void cb_pcimdda_detach(struct comedi_device *dev)
		struct pci_dev *pcidev = comedi_to_pci_dev(dev);

		if (dev->subdevices)
		subdev_8255_cleanup(dev, dev->subdevices + 2);
		subdev_8255_cleanup(dev, dev->subdevices + 1);
		if (pcidev) {
		if (dev->iobase)
		comedi_pci_disable(pcidev);

Admin message