Commit c79e167c authored Dec 04, 2016 by Pan Bian Committed by David S. Miller Dec 05, 2016

net: caif: remove ineffective check

The check of the return value of sock_register() is ineffective.
"if(!err)" seems to be a typo. It is better to propagate the error code
to the callers of caif_sktinit_module(). This patch removes the check
statment and directly returns the result of sock_register().

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751


Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0eab121e

net/caif/caif_socket.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1107,10 +1107,7 @@ static struct net_proto_family caif_family_ops = {

		static int __init caif_sktinit_module(void)
		{
		int err = sock_register(&caif_family_ops);
		if (!err)
		return err;
		return 0;
		return sock_register(&caif_family_ops);
		}

		static void __exit caif_sktexit_module(void)

Admin message