Commit c783d525 authored by Jann Horn's avatar Jann Horn Committed by Micah Morton
Browse files

LSM: SafeSetID: fix pr_warn() to include newline 



Fix the pr_warn() calls in the SafeSetID LSM to have newlines at the end.
Without this, denial messages will be buffered as incomplete lines in
log_output(), and will then only show up once something else prints into
dmesg.

Signed-off-by: default avatarJann Horn <jannh@google.com>
Signed-off-by: default avatarMicah Morton <mortonm@chromium.org>
parent fec88ab0

security/safesetid/lsm.c

+2 −2
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ static int safesetid_security_capable(const struct cred *cred, 
			 * to functionality other than calling set*uid() (e.g.

			 * allowing user to set up userns uid mappings).

			 */

			pr_warn("Operation requires CAP_SETUID, which is not available to UID %u for operations besides approved set*uid transitions",

			pr_warn("Operation requires CAP_SETUID, which is not available to UID %u for operations besides approved set*uid transitions\n",

				__kuid_val(cred->uid));

			return -1;

		}
@@ -103,7 +103,7 @@ static int check_uid_transition(kuid_t parent, kuid_t child) 
{

	if (check_setuid_policy_hashtable_key_value(parent, child))

		return 0;

	pr_warn("UID transition (%d -> %d) blocked",

	pr_warn("UID transition (%d -> %d) blocked\n",

		__kuid_val(parent),

		__kuid_val(child));

	/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE