Commit c78193e9 authored Apr 18, 2011 by Linus Torvalds

next_pidmap: fix overflow condition



next_pidmap() just quietly accepted whatever 'last' pid that was passed
in, which is not all that safe when one of the users is /proc.

Admittedly the proc code should do some sanity checking on the range
(and that will be the next commit), but that doesn't mean that the
helper functions should just do that pidmap pointer arithmetic without
checking the range of its arguments.

So clamp 'last' to PID_MAX_LIMIT.  The fact that we then do "last+1"
doesn't really matter, the for-loop does check against the end of the
pidmap array properly (it's only the actual pointer arithmetic overflow
case we need to worry about, and going one bit beyond isn't going to
overflow).

[ Use PID_MAX_LIMIT rather than pid_max as per Eric Biederman ]

Reported-by: Tavis Ormandy <taviso@cmpxchg8b.com>
Analyzed-by: Robert Święcki <robert@swiecki.net>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a1b49cb7

include/linux/pid.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -117,7 +117,7 @@ extern struct pid *find_vpid(int nr);
		*/
		extern struct pid *find_get_pid(int nr);
		extern struct pid find_ge_pid(int nr, struct pid_namespace );
		int next_pidmap(struct pid_namespace *pid_ns, int last);
		int next_pidmap(struct pid_namespace *pid_ns, unsigned int last);

		extern struct pid alloc_pid(struct pid_namespace ns);
		extern void free_pid(struct pid *pid);

kernel/pid.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -217,11 +217,14 @@ static int alloc_pidmap(struct pid_namespace *pid_ns)
		return -1;
		}

		int next_pidmap(struct pid_namespace *pid_ns, int last)
		int next_pidmap(struct pid_namespace *pid_ns, unsigned int last)
		{
		int offset;
		struct pidmap map, end;

		if (last >= PID_MAX_LIMIT)
		return -1;

		offset = (last + 1) & BITS_PER_PAGE_MASK;
		map = &pid_ns->pidmap[(last + 1)/BITS_PER_PAGE];
		end = &pid_ns->pidmap[PIDMAP_ENTRIES];

Admin message