Commit c769accd authored Mar 29, 2018 by Toshiaki Makita Committed by David S. Miller Mar 30, 2018

vlan: Fix vlan insertion for packets without ethernet header

In some situation vlan packets do not have ethernet headers. One example
is packets from tun devices. Users can specify vlan protocol in tun_pi
field instead of IP protocol. When we have a vlan device with reorder_hdr
disabled on top of the tun device, such packets from tun devices are
untagged in skb_vlan_untag() and vlan headers will be inserted back in
vlan_insert_inner_tag().

vlan_insert_inner_tag() however did not expect packets without ethernet
headers, so in such a case size argument for memmove() underflowed.

We don't need to copy headers for packets which do not have preceding
headers of vlan headers, so skip memmove() in that case.
Also don't write vlan protocol in skb->data when it does not have enough
room for it.

Fixes: cbe7128c ("vlan: Fix out of order vlan headers with reorder header off")
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ae474573

include/linux/if_vlan.h

+13 −2

Original line number	Diff line number	Diff line
		@@ -323,13 +323,24 @@ static inline int __vlan_insert_inner_tag(struct sk_buff *skb,
		skb_push(skb, VLAN_HLEN);

		/* Move the mac header sans proto to the beginning of the new header. */
		if (likely(mac_len > ETH_TLEN))
		memmove(skb->data, skb->data + VLAN_HLEN, mac_len - ETH_TLEN);
		skb->mac_header -= VLAN_HLEN;

		veth = (struct vlan_ethhdr *)(skb->data + mac_len - ETH_HLEN);

		/* first, the ethernet type */
		if (likely(mac_len >= ETH_TLEN)) {
		/* h_vlan_encapsulated_proto should already be populated, and
		* skb->data has space for h_vlan_proto
		*/
		veth->h_vlan_proto = vlan_proto;
		} else {
		/* h_vlan_encapsulated_proto should not be populated, and
		* skb->data has no space for h_vlan_proto
		*/
		veth->h_vlan_encapsulated_proto = skb->protocol;
		}

		/* now, the TCI */
		veth->h_vlan_TCI = htons(vlan_tci);

Admin message