Commit c7529392 authored Jul 28, 2020 by Mat Martineau Committed by David S. Miller Jul 28, 2020

mptcp: Safely read sequence number when lock isn't held



The MPTCP socket's write_seq member should be read with READ_ONCE() when
the msk lock is not held.

Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 06827b34

net/mptcp/protocol.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1269,7 +1269,7 @@ static void mptcp_retransmit_handler(struct sock *sk)
		{
		struct mptcp_sock *msk = mptcp_sk(sk);

		if (atomic64_read(&msk->snd_una) == msk->write_seq) {
		if (atomic64_read(&msk->snd_una) == READ_ONCE(msk->write_seq)) {
		mptcp_stop_timer(sk);
		} else {
		set_bit(MPTCP_WORK_RTX, &msk->flags);

Admin message