Commit c746b6b6 authored Feb 01, 2019 by Rafael J. Wysocki

ACPI: EC: Make acpi_ec_dsdt_probe() more straightforward

Since acpi_ec_dsdt_probe() returns early if boot_ec is set, it is
always unset when that function calls acpi_config_boot_ec() (passing
ec->handle as the handle argument to it). Thus it is not really
useful to call acpi_config_boot_ec() at that point. It is sufficient to
call acpi_ec_setup() directly and (if that is successful) set boot_ec,
so make acpi_ec_dsdt_probe() do that and avoid some pointless checks
in acpi_config_boot_ec().

No intentional functional impact except for a changed message.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 1568426c

drivers/acpi/ec.c

+9 −2

Original line number	Diff line number	Diff line
		@@ -1768,9 +1768,16 @@ void __init acpi_ec_dsdt_probe(void)
		* At this point, the GPE is not fully initialized, so do not to
		* handle the events.
		*/
		ret = acpi_config_boot_ec(ec, ec->handle, false, false);
		if (ret)
		ret = acpi_ec_setup(ec, false);
		if (ret) {
		acpi_ec_free(ec);
		return;
		}

		boot_ec = ec;

		acpi_handle_info(ec->handle,
		"Boot DSDT EC used to handle transactions\n");
		}

		/*

Admin message