sched/debug: Remove redundant macro define (c745a621) · Commits · 戴 / test

Most printing macros for procfs are defined globally in debug.c, and they are re-defined (to the exact same thing) within proc_sched_show_task(). Get rid of the duplicate defines. Reviewed-by:

Qais Yousef <qais.yousef@arm.com> Signed-off-by:

Valentin Schneider <valentin.schneider@arm.com> Signed-off-by:

Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by:

Ingo Molnar <mingo@kernel.org> Link: https://lkml.kernel.org/r/20200226124543.31986-2-valentin.schneider@arm.com

kernel/sched/debug.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -868,16 +868,8 @@ void proc_sched_show_task(struct task_struct p, struct pid_namespace ns,
		SEQ_printf(m,
		"---------------------------------------------------------"
		"----------\n");
		#define __P(F) \
		SEQ_printf(m, "%-45s:%21Ld\n", #F, (long long)F)
		#define P(F) \
		SEQ_printf(m, "%-45s:%21Ld\n", #F, (long long)p->F)
		#define P_SCHEDSTAT(F) \
		SEQ_printf(m, "%-45s:%21Ld\n", #F, (long long)schedstat_val(p->F))
		#define __PN(F) \
		SEQ_printf(m, "%-45s:%14Ld.%06ld\n", #F, SPLIT_NS((long long)F))
		#define PN(F) \
		SEQ_printf(m, "%-45s:%14Ld.%06ld\n", #F, SPLIT_NS((long long)p->F))
		#define PN_SCHEDSTAT(F) \
		SEQ_printf(m, "%-45s:%14Ld.%06ld\n", #F, SPLIT_NS((long long)schedstat_val(p->F)))

		@@ -963,11 +955,7 @@ void proc_sched_show_task(struct task_struct p, struct pid_namespace ns,
		P(dl.deadline);
		}
		#undef PN_SCHEDSTAT
		#undef PN
		#undef __PN
		#undef P_SCHEDSTAT
		#undef P
		#undef __P

		{
		unsigned int this_cpu = raw_smp_processor_id();

Admin message