Commit c7351845 authored by YueHaibing's avatar YueHaibing Committed by Herbert Xu
Browse files

crypto: sun8i-ce - Fix memdup.cocci warnings 



Use kmemdup rather than duplicating its implementation

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Acked-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent d6e9da21

drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c

+2 −4
Original line number Diff line number Diff line
@@ -396,10 +396,9 @@ int sun8i_ce_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, 
		kfree(op->key);

	}

	op->keylen = keylen;

	op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);

	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);

	if (!op->key)

		return -ENOMEM;

	memcpy(op->key, key, keylen);



	crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);

	crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);
@@ -422,10 +421,9 @@ int sun8i_ce_des3_setkey(struct crypto_skcipher *tfm, const u8 *key, 
		kfree(op->key);

	}

	op->keylen = keylen;

	op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);

	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);

	if (!op->key)

		return -ENOMEM;

	memcpy(op->key, key, keylen);



	crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);

	crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);

CRA Git | Maintained and supported by SUSTech CRA and CCSE