Commit c73455e1 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: FLOGI failures are reported when connected to a private loop. 



When the HBA is connected to a private loop, the driver reports FLOGI
loop-open failure as functional error. This is an expected condition.

Mark loop-open failure as a warning instead of error.

Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 02000b19

drivers/scsi/lpfc/lpfc_els.c

+14 −13
Original line number Diff line number Diff line
@@ -1030,9 +1030,12 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, 


stop_rr_fcf_flogi:

		/* FLOGI failure */

		if (!(irsp->ulpStatus == IOSTAT_LOCAL_REJECT &&

		      ((irsp->un.ulpWord[4] & IOERR_PARAM_MASK) ==

					IOERR_LOOP_OPEN_FAILURE)))

			lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,

				"2858 FLOGI failure Status:x%x/x%x TMO:x%x "

				"Data x%x x%x\n",

					"2858 FLOGI failure Status:x%x/x%x "

					"TMO:x%x Data x%x x%x\n",

					irsp->ulpStatus, irsp->un.ulpWord[4],

					irsp->ulpTimeout, phba->hba_flag,

					phba->fcf.fcf_flag);
@@ -1041,19 +1044,17 @@ stop_rr_fcf_flogi: 
		if (lpfc_els_retry(phba, cmdiocb, rspiocb))

			goto out;



		/* FLOGI failure */

		lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,

				 "0100 FLOGI failure Status:x%x/x%x TMO:x%x\n",

				 irsp->ulpStatus, irsp->un.ulpWord[4],

				 irsp->ulpTimeout);





		/* If this is not a loop open failure, bail out */

		if (!(irsp->ulpStatus == IOSTAT_LOCAL_REJECT &&

		      ((irsp->un.ulpWord[4] & IOERR_PARAM_MASK) ==

					IOERR_LOOP_OPEN_FAILURE)))

			goto flogifail;



		lpfc_printf_vlog(vport, KERN_WARNING, LOG_ELS,

				 "0150 FLOGI failure Status:x%x/x%x TMO:x%x\n",

				 irsp->ulpStatus, irsp->un.ulpWord[4],

				 irsp->ulpTimeout);



		/* FLOGI failed, so there is no fabric */

		spin_lock_irq(shost->host_lock);

		vport->fc_flag &= ~(FC_FABRIC | FC_PUBLIC_LOOP);

CRA Git | Maintained and supported by SUSTech CRA and CCSE