Commit c725dafc authored Nov 03, 2020 by Sebastian Andrzej Siewior Committed by Thomas Gleixner Nov 15, 2020

timers: Don't block on ->expiry_lock for TIMER_IRQSAFE timers

PREEMPT_RT does not spin and wait until a running timer completes its
callback but instead it blocks on a sleeping lock to prevent a livelock in
the case that the task waiting for the callback completion preempted the
callback.

This cannot be done for timers flagged with TIMER_IRQSAFE. These timers can
be canceled from an interrupt disabled context even on RT kernels.

The expiry callback of such timers is invoked with interrupts disabled so
there is no need to use the expiry lock mechanism because obviously the
callback cannot be preempted even on RT kernels.

Do not use the timer_base::expiry_lock mechanism when waiting for a running
callback to complete if the timer is flagged with TIMER_IRQSAFE.

Also add a lockdep assertion for RT kernels to validate that the expiry
lock mechanism is always invoked in preemptible context.

Reported-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20201103190937.hga67rqhvknki3tp@linutronix.de

parent da88f9b3

kernel/time/timer.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -1288,7 +1288,7 @@ static void del_timer_wait_running(struct timer_list *timer)
		u32 tf;

		tf = READ_ONCE(timer->flags);
		if (!(tf & TIMER_MIGRATING)) {
		if (!(tf & (TIMER_MIGRATING \| TIMER_IRQSAFE))) {
		struct timer_base *base = get_timer_base(tf);

		/*
		@@ -1372,6 +1372,13 @@ int del_timer_sync(struct timer_list *timer)
		*/
		WARN_ON(in_irq() && !(timer->flags & TIMER_IRQSAFE));

		/*
		* Must be able to sleep on PREEMPT_RT because of the slowpath in
		* del_timer_wait_running().
		*/
		if (IS_ENABLED(CONFIG_PREEMPT_RT) && !(timer->flags & TIMER_IRQSAFE))
		lockdep_assert_preemption_enabled();

		do {
		ret = try_to_del_timer_sync(timer);

Admin message