Commit c70d6505 authored Jul 03, 2013 by Mika Westerberg Committed by Rafael J. Wysocki Jul 23, 2013

x86 / PCI: prevent re-allocation of already existing bridge and ROM resources

In hotplug case (especially with Thunderbolt enabled systems) we might need
to call pcibios_resource_survey_bus() several times for a bus. The function
ends up calling pci_claim_resource() for each bridge resource that then
fails claiming that the resource exists already (which it does). Once this
happens the resource is invalidated thus preventing devices behind the
bridge to allocate their resources.

To fix this we do what has been done in pcibios_allocate_dev_resources()
and check 'parent' of the given resource. If it is non-NULL it means that
the resource has been allocated already and we can skip it. We do the same
for ROM resources as well.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 3b2f64d0

arch/x86/pci/i386.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -210,6 +210,8 @@ static void pcibios_allocate_bridge_resources(struct pci_dev *dev)
		r = &dev->resource[idx];
		if (!r->flags)
		continue;
		if (r->parent) /* Already allocated */
		continue;
		if (!r->start \|\| pci_claim_resource(dev, idx) < 0) {
		/*
		* Something is wrong with the region.
		@@ -318,6 +320,8 @@ static void pcibios_allocate_dev_rom_resource(struct pci_dev *dev)
		r = &dev->resource[PCI_ROM_RESOURCE];
		if (!r->flags \|\| !r->start)
		return;
		if (r->parent) /* Already allocated */
		return;

		if (pci_claim_resource(dev, PCI_ROM_RESOURCE) < 0) {
		r->end -= r->start;

Admin message