Commit c70011a9 authored Jun 15, 2020 by Maxime Ripard Committed by Stephen Boyd Jun 19, 2020

clk: bcm: rpi: Remove global pllb_arm clock pointer



The pllb_arm clk_hw pointer in the raspberry_clk structure isn't used
anywhere but in the raspberrypi_register_pllb_arm.

Let's remove it, this will make our lives easier in future patches.

Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/842859cf1a77478620f45049178a588448202858.1592210452.git-series.maxime@cerno.tech


Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 72856a4e

drivers/clk/bcm/clk-raspberrypi.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -40,7 +40,6 @@ struct raspberrypi_clk {
		unsigned long max_rate;

		struct clk_hw pllb;
		struct clk_hw *pllb_arm;
		struct clk_lookup *pllb_arm_lookup;
		};

		@@ -246,12 +245,12 @@ static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi)
		dev_err(rpi->dev, "Failed to initialize pllb_arm\n");
		return ret;
		}
		rpi->pllb_arm = &raspberrypi_clk_pllb_arm.hw;

		rpi->pllb_arm_lookup = clkdev_hw_create(rpi->pllb_arm, NULL, "cpu0");
		rpi->pllb_arm_lookup = clkdev_hw_create(&raspberrypi_clk_pllb_arm.hw,
		NULL, "cpu0");
		if (!rpi->pllb_arm_lookup) {
		dev_err(rpi->dev, "Failed to initialize pllb_arm_lookup\n");
		clk_hw_unregister_fixed_factor(rpi->pllb_arm);
		clk_hw_unregister_fixed_factor(&raspberrypi_clk_pllb_arm.hw);
		return -ENOMEM;
		}

Admin message