Commit c6e45ae5 authored Jul 11, 2020 by Andy Shevchenko Committed by Greg Kroah-Hartman Jul 21, 2020

Revert "tty: serial: add missing spin_lock_init for SiFive serial console"

This reverts commit 17b4efdf.

There has been a quick fix against uninitialised lock revealed by
the commit f743061a ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.

Fixes: 17b4efdf ("tty: serial: add missing spin_lock_init for SiFive serial console")
Depends-on: f743061a ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-3-andriy.shevchenko@linux.intel.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6a63ba97

drivers/tty/serial/sifive.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -883,7 +883,6 @@ console_initcall(sifive_console_init);

		static void __ssp_add_console_port(struct sifive_serial_port *ssp)
		{
		spin_lock_init(&ssp->port.lock);
		sifive_serial_console_ports[ssp->port.line] = ssp;
		}