Commit c6d6a511 authored Sep 18, 2008 by Lennert Buytenhek Committed by David S. Miller Oct 08, 2008

phylib: phy_mii_ioctl() fixes



Make the SIOCGMIIPHY case fall through properly (it is supposed
to not only return the ID of the default PHY but also to read from
that PHY), and make phy_mii_ioctl() return the same error code as
generic_mii_ioctl() in case of an unsupported operation.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Acked-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4dd56513

drivers/net/phy/phy.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -366,7 +366,8 @@ int phy_mii_ioctl(struct phy_device *phydev,
		switch (cmd) {
		case SIOCGMIIPHY:
		mii_data->phy_id = phydev->addr;
		break;
		/* fall through */

		case SIOCGMIIREG:
		mii_data->val_out = phy_read(phydev, mii_data->reg_num);
		break;
		@@ -413,7 +414,7 @@ int phy_mii_ioctl(struct phy_device *phydev,
		break;

		default:
		return -ENOTTY;
		return -EOPNOTSUPP;
		}

		return 0;

Admin message