Commit c6cb898b authored Dec 10, 2014 by Yann Droneaud Committed by Linus Torvalds Dec 10, 2014

binfmt_misc: replace get_unused_fd() with get_unused_fd_flags(0)



This patch replaces calls to get_unused_fd() with equivalent call to
get_unused_fd_flags(0) to preserve current behavor for existing code.

In a further patch, get_unused_fd() will be removed so that new code start
using get_unused_fd_flags(), with the hope O_CLOEXEC could be used, either
by default or choosen by userspace.

Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6b9cdf39

fs/binfmt_misc.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -153,7 +153,7 @@ static int load_misc_binary(struct linux_binprm *bprm)
	/* if the binary should be opened on behalf of the		/* if the binary should be opened on behalf of the
	* interpreter than keep it open and assign descriptor		* interpreter than keep it open and assign descriptor
	* to it */		* to it */
	fd_binary = get_unused_fd();		fd_binary = get_unused_fd_flags(0);
	if (fd_binary < 0) {		if (fd_binary < 0) {
	retval = fd_binary;		retval = fd_binary;
	goto _ret;		goto _ret;

Admin message