Commit c6b8e793 authored Sep 18, 2017 by Adam Wallis Committed by Greg Kroah-Hartman Sep 18, 2017

usb: host: xhci-plat: allow sysdev to inherit from ACPI



Commit 4c39d4b9 ("usb: xhci: use bus->sysdev for DMA configuration")
updated the method determining DMA for XHCI from sysdev. However, this
patch broke the ability to enumerate the FWNODE from parent ACPI devices
from the child plat XHCI device.

Currently, xhci_plat is not set up properly when the parent device is an
ACPI node. The conditions that xhci_plat_probe should satisfy are

1. xhci_plat comes from firmware
2. xhci_plat is child of a device from firmware (dwc3-plat)
3. xhci_plat is grandchild of a pci device (dwc3-pci)

Case 2 is covered when the child is an OF node (by checking
sysdev->parent->of_node), however, an ACPI parent will return NULL in
the of_node check and will thus not result in sysdev being set to
sysdev->parent

[   17.591549] xhci-hcd: probe of xhci-hcd.6.auto failed with error -5

This change adds a check for ACPI to completely allow for condition 2.
This is done by first checking if the parent node is of type ACPI (e.g.,
dwc3-plat) and set sysdev to sysdev->parent if either of the two
following conditions are met:

1: If fwnode is empty (in the case that platform_device_add_properties
was not called on the allocated platform device)
2: fwnode exists but is not of type ACPI (this would happen if
platform_device_add_properties was called on the allocated device.
Instead of type FWNODE_ACPI, you would end up with FWNODE_PDATA)

Cc: stable@vger.kernel.org #4.12.x
Cc: stable@vger.kernel.org #4.13.x

Fixes: 4c39d4b9 ("usb: xhci: use bus->sysdev for DMA configuration")
Tested-by: Thang Q. Nguyen <tqnguyen@apm.com>
Signed-off-by: Adam Wallis <awallis@codeaurora.org>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 76a14d7b

drivers/usb/host/xhci-plat.c

+10 −6

Original line number	Diff line number	Diff line
		@@ -178,14 +178,18 @@ static int xhci_plat_probe(struct platform_device *pdev)
		* 2. xhci_plat is child of a device from firmware (dwc3-plat)
		* 3. xhci_plat is grandchild of a pci device (dwc3-pci)
		*/
		sysdev = &pdev->dev;
		if (sysdev->parent && !sysdev->of_node && sysdev->parent->of_node)
		sysdev = sysdev->parent;
		for (sysdev = &pdev->dev; sysdev; sysdev = sysdev->parent) {
		if (is_of_node(sysdev->fwnode) \|\|
		is_acpi_device_node(sysdev->fwnode))
		break;
		#ifdef CONFIG_PCI
		else if (sysdev->parent && sysdev->parent->parent &&
		sysdev->parent->parent->bus == &pci_bus_type)
		sysdev = sysdev->parent->parent;
		else if (sysdev->bus == &pci_bus_type)
		break;
		#endif
		}

		if (!sysdev)
		sysdev = &pdev->dev;

		/* Try to set 64-bit DMA first */
		if (WARN_ON(!sysdev->dma_mask))

Admin message