Commit c6b5eb8d authored Jul 30, 2018 by Jia-Ju Bai Committed by Alexandre Belloni Aug 27, 2018

rtc: rtc-mrst: Replace mdelay() with msleep() in mrst_read_time()



mrst_read_time() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

parent 5b394b2d

drivers/rtc/rtc-mrst.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -90,7 +90,7 @@ static int mrst_read_time(struct device dev, struct rtc_time time)
		unsigned long flags;

		if (vrtc_is_updating())
		mdelay(20);
		msleep(20);

		spin_lock_irqsave(&rtc_lock, flags);
		time->tm_sec = vrtc_cmos_read(RTC_SECONDS);

Admin message