Commit c6b471e6 authored Feb 07, 2010 by Herbert Xu Committed by David S. Miller Feb 12, 2010

inet: Remove bogus IGMPv3 report handling



Currently we treat IGMPv3 reports as if it were an IGMPv2/v1 report.
This is broken as IGMPv3 reports are formatted differently.  So we
end up suppressing a bogus multicast group (which should be harmless
as long as the leading reserved field is zero).

In fact, IGMPv3 does not allow membership report suppression so
we should simply ignore IGMPv3 membership reports as a host.

This patch does exactly that.  I kept the case statement for it
so people won't accidentally add it back thinking that we overlooked
this case.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 59885640

net/ipv4/igmp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -946,7 +946,6 @@ int igmp_rcv(struct sk_buff *skb)
		break;
		case IGMP_HOST_MEMBERSHIP_REPORT:
		case IGMPV2_HOST_MEMBERSHIP_REPORT:
		case IGMPV3_HOST_MEMBERSHIP_REPORT:
		/* Is it our report looped back? */
		if (skb_rtable(skb)->fl.iif == 0)
		break;
		@@ -960,6 +959,7 @@ int igmp_rcv(struct sk_buff *skb)
		in_dev_put(in_dev);
		return pim_rcv_v1(skb);
		#endif
		case IGMPV3_HOST_MEMBERSHIP_REPORT:
		case IGMP_DVMRP:
		case IGMP_TRACE:
		case IGMP_HOST_LEAVE_MESSAGE:

Admin message