Commit c69ad71b authored Aug 05, 2008 by David Brownell Committed by Linus Torvalds Aug 05, 2008

genirq: better warning on irqchip->set_type() failure



While I'm glad to finally see the hole fixed whereby passing an invalid
IRQ trigger type to request_irq() would be ignored, the current diagnostic
isn't quite useful.  Fixed by also listing the trigger type which was
rejected.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 5b2becc8

kernel/irq/manage.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -323,7 +323,8 @@ static int __irq_set_trigger(struct irq_chip *chip, unsigned int irq,
		ret = chip->set_type(irq, flags & IRQF_TRIGGER_MASK);

		if (ret)
		pr_err("setting flow type for irq %u failed (%pF)\n",
		pr_err("setting trigger mode %d for irq %u failed (%pF)\n",
		(int)(flags & IRQF_TRIGGER_MASK),
		irq, chip->set_type);

		return ret;

Admin message