Commit c69565ee authored Jul 30, 2019 by David Howells

rxrpc: Fix the lack of notification when sendmsg() fails on a DATA packet



Fix the fact that a notification isn't sent to the recvmsg side to indicate
a call failed when sendmsg() fails to transmit a DATA packet with the error
ENETUNREACH, EHOSTUNREACH or ECONNREFUSED.

Without this notification, the afs client just sits there waiting for the
call to complete in some manner (which it's not now going to do), which
also pins the rxrpc call in place.

This can be seen if the client has a scope-level IPv6 address, but not a
global-level IPv6 address, and we try and transmit an operation to a
server's IPv6 address.

Looking in /proc/net/rxrpc/calls shows completed calls just sat there with
an abort code of RX_USER_ABORT and an error code of -ENETUNREACH.

Fixes: c54e43d7 ("rxrpc: Fix missing start of call timeout")
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>

parent 60034d3d

net/rxrpc/sendmsg.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -226,6 +226,7 @@ static int rxrpc_queue_packet(struct rxrpc_sock rx, struct rxrpc_call call,
		rxrpc_set_call_completion(call,
		RXRPC_CALL_LOCAL_ERROR,
		0, ret);
		rxrpc_notify_socket(call);
		goto out;
		}
		_debug("need instant resend %d", ret);

Admin message