Commit c69480ad authored Apr 29, 2013 by Joonsoo Kim Committed by Linus Torvalds Apr 29, 2013

mm, vmalloc: protect va->vm by vmap_area_lock



Inserting and removing an entry to vmlist is linear time complexity, so
it is inefficient.  Following patches will try to remove vmlist
entirely.  This patch is preparing step for it.

For removing vmlist, iterating vmlist codes should be changed to
iterating a vmap_area_list.  Before implementing that, we should make
sure that when we iterate a vmap_area_list, accessing to va->vm doesn't
cause a race condition.  This patch ensure that when iterating a
vmap_area_list, there is no race condition for accessing to vm_struct.

Signed-off-by: Joonsoo Kim <js1304@gmail.com>
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Cc: Dave Anderson <anderson@redhat.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent db3808c1

mm/vmalloc.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1290,12 +1290,14 @@ struct vm_struct *vmlist;
		static void setup_vmalloc_vm(struct vm_struct vm, struct vmap_area va,
		unsigned long flags, const void *caller)
		{
		spin_lock(&vmap_area_lock);
		vm->flags = flags;
		vm->addr = (void *)va->va_start;
		vm->size = va->va_end - va->va_start;
		vm->caller = caller;
		va->vm = vm;
		va->flags \|= VM_VM_AREA;
		spin_unlock(&vmap_area_lock);
		}

		static void insert_vmalloc_vmlist(struct vm_struct *vm)
		@@ -1447,6 +1449,11 @@ struct vm_struct remove_vm_area(const void addr)
		if (va && va->flags & VM_VM_AREA) {
		struct vm_struct *vm = va->vm;

		spin_lock(&vmap_area_lock);
		va->vm = NULL;
		va->flags &= ~VM_VM_AREA;
		spin_unlock(&vmap_area_lock);

		if (!(vm->flags & VM_UNLIST)) {
		struct vm_struct tmp, *p;
		/*

Admin message