Unverified Commit c68f47aa authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: lm363x: Check return value of gpiod_get_index_optional 



gpiod_get_index_optional can return ERR_PTR, add IS_ERR checking for it.
While at it, also remove a redundant NULL test for gpiod in error path.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b735f41d

drivers/regulator/lm363x-regulator.c

+4 −2
Original line number Diff line number Diff line
@@ -258,6 +258,9 @@ static int lm363x_regulator_probe(struct platform_device *pdev) 
	 * Register update is required if the pin is used.

	 */

	gpiod = lm363x_regulator_of_get_enable_gpio(dev, id);

	if (IS_ERR(gpiod))

		return PTR_ERR(gpiod);



	if (gpiod) {

		cfg.ena_gpiod = gpiod;
@@ -265,7 +268,6 @@ static int lm363x_regulator_probe(struct platform_device *pdev) 
					 LM3632_EXT_EN_MASK,

					 LM3632_EXT_EN_MASK);

		if (ret) {

			if (gpiod)

			gpiod_put(gpiod);

			dev_err(dev, "External pin err: %d\n", ret);

			return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE