Commit c678ef52 authored Apr 03, 2013 by Arnd Bergmann Committed by Jens Axboe Apr 03, 2013

block: avoid using uninitialized value in from queue_var_store



As found by gcc-4.8, the QUEUE_SYSFS_BIT_FNS macro creates functions
that use a value generated by queue_var_store independent of whether
that value was set or not.

block/blk-sysfs.c: In function 'queue_store_nonrot':
block/blk-sysfs.c:244:385: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]

Unlike most other such warnings, this one is not a false positive,
writing any non-number string into the sysfs files indeed has
an undefined result, rather than returning an error.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 07961ac7

block/blk-sysfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -229,6 +229,8 @@ queue_store_##name(struct request_queue q, const char page, size_t count) \
		unsigned long val; \
		ssize_t ret; \
		ret = queue_var_store(&val, page, count); \
		if (ret < 0) \
		return ret; \
		if (neg) \
		val = !val; \
		\

Admin message