Commit c67625a1 authored Nov 14, 2007 by Pavel Emelyanov Committed by David S. Miller Nov 14, 2007

[NET]: Remove notifier block from chain when register_netdevice_notifier fails



Commit fcc5a03a:

	[NET]: Allow netdev REGISTER/CHANGENAME events to fail

makes the register_netdevice_notifier() handle the error from the
NETDEV_REGISTER event, sent to the registering block.

The bad news is that in this case the notifier block is 
not removed from the list, but the error is returned to the 
caller. In case the caller is in module init function and 
handles this error this can abort the module loading. The
notifier block will be then removed from the kernel, but 
will be left in the list. Oops :(

I think that the notifier block should be removed from the
chain in case of error, regardless whether this error is 
handled by the caller or not. In the worst case (the error 
is _not_ handled) module will not receive the events any 
longer.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8a856397

net/core/dev.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1171,6 +1171,8 @@ rollback:
		nb->notifier_call(nb, NETDEV_UNREGISTER, dev);
		}
		}

		raw_notifier_chain_unregister(&netdev_chain, nb);
		goto unlock;
		}

Admin message