Commit c66ebf2d authored Dec 03, 2016 by Pan Bian Committed by David S. Miller Dec 03, 2016

net: dcb: set error code on failures

In function dcbnl_cee_fill(), returns the value of variable err on
errors. However, on some error paths (e.g. nla put fails), its value may
be 0. It may be better to explicitly set a negative errno to variable
err before returning.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188881



Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a38b6100

net/dcb/dcbnl.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1353,6 +1353,7 @@ static int dcbnl_cee_fill(struct sk_buff skb, struct net_device netdev)
		dcb_unlock:
		spin_unlock_bh(&dcb_lock);
		nla_put_failure:
		err = -EMSGSIZE;
		return err;
		}

Admin message