Commit c65da8e2 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'acpi-4.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm 

Pull ACPI fixes from Rafael Wysocki:
 "These fix the initialization of resources in the ACPI WDAT watchdog
  driver, a recent regression in the ACPI device properties handling, a
  recent change in behavior causing the ACPI_HANDLE() macro to only work
  for GPL code and create a MAINTAINERS entry for ACPI PMIC drivers in
  order to specify the official reviewers for that code.

  Specifics:

   - Fix the initialization of resources in the ACPI WDAT watchdog
     driver that uses unititialized memory which causes compiler
     warnings to be triggered (Arnd Bergmann).

   - Fix a recent regression in the ACPI device properties handling that
     causes some device properties data to be skipped during enumeration
     (Sakari Ailus).

   - Fix a recent change in behavior that caused the ACPI_HANDLE() macro
     to stop working for non-GPL code which is a problem for the NVidia
     binary graphics driver, for example (John Hubbard).

   - Add a MAINTAINERS entry for the ACPI PMIC drivers to specify the
     official reviewers for that code (Rafael Wysocki)"

* tag 'acpi-4.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
  ACPI: properties: Return _DSD hierarchical extension (data) sub-nodes correctly
  ACPI / bus: Make ACPI_HANDLE() work for non-GPL code again
  ACPI / watchdog: properly initialize resources
  ACPI / PMIC: Add code reviewers to MAINTAINERS
parents 6876eb37 672d0e45

MAINTAINERS

+12 −0
Original line number Diff line number Diff line
@@ -352,6 +352,18 @@ L: linux-acpi@vger.kernel.org 
S:	Maintained

F:	drivers/acpi/arm64



ACPI PMIC DRIVERS

M:	"Rafael J. Wysocki" <rjw@rjwysocki.net>

M:	Len Brown <lenb@kernel.org>

R:	Andy Shevchenko <andy@infradead.org>

R:	Mika Westerberg <mika.westerberg@linux.intel.com>

L:	linux-acpi@vger.kernel.org

Q:	https://patchwork.kernel.org/project/linux-acpi/list/

T:	git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

B:	https://bugzilla.kernel.org

S:	Supported

F:	drivers/acpi/pmic/



ACPI THERMAL DRIVER

M:	Zhang Rui <rui.zhang@intel.com>

L:	linux-acpi@vger.kernel.org

drivers/acpi/acpi_watchdog.c

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ void __init acpi_watchdog_init(void) 
	for (i = 0; i < wdat->entries; i++) {

		const struct acpi_generic_address *gas;

		struct resource_entry *rentry;

		struct resource res;

		struct resource res = {};

		bool found;



		gas = &entries[i].register_region;

drivers/acpi/property.c

+19 −5
Original line number Diff line number Diff line
@@ -908,11 +908,12 @@ struct fwnode_handle *acpi_get_next_subnode(const struct fwnode_handle *fwnode, 
					    struct fwnode_handle *child)

{

	const struct acpi_device *adev = to_acpi_device_node(fwnode);

	struct acpi_device *child_adev = NULL;

	const struct list_head *head;

	struct list_head *next;



	if (!child || is_acpi_device_node(child)) {

		struct acpi_device *child_adev;



		if (adev)

			head = &adev->children;

		else
@@ -922,8 +923,8 @@ struct fwnode_handle *acpi_get_next_subnode(const struct fwnode_handle *fwnode, 
			goto nondev;



		if (child) {

			child_adev = to_acpi_device_node(child);

			next = child_adev->node.next;

			adev = to_acpi_device_node(child);

			next = adev->node.next;

			if (next == head) {

				child = NULL;

				goto nondev;
@@ -941,8 +942,8 @@ struct fwnode_handle *acpi_get_next_subnode(const struct fwnode_handle *fwnode, 
		const struct acpi_data_node *data = to_acpi_data_node(fwnode);

		struct acpi_data_node *dn;



		if (child_adev)

			head = &child_adev->data.subnodes;

		if (adev)

			head = &adev->data.subnodes;

		else if (data)

			head = &data->data.subnodes;

		else
@@ -1293,3 +1294,16 @@ static int acpi_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, 
DECLARE_ACPI_FWNODE_OPS(acpi_device_fwnode_ops);

DECLARE_ACPI_FWNODE_OPS(acpi_data_fwnode_ops);

const struct fwnode_operations acpi_static_fwnode_ops;



bool is_acpi_device_node(const struct fwnode_handle *fwnode)

{

	return !IS_ERR_OR_NULL(fwnode) &&

		fwnode->ops == &acpi_device_fwnode_ops;

}

EXPORT_SYMBOL(is_acpi_device_node);



bool is_acpi_data_node(const struct fwnode_handle *fwnode)

{

	return !IS_ERR_OR_NULL(fwnode) && fwnode->ops == &acpi_data_fwnode_ops;

}

EXPORT_SYMBOL(is_acpi_data_node);

include/acpi/acpi_bus.h

+4 −14
Original line number Diff line number Diff line
@@ -399,17 +399,12 @@ extern const struct fwnode_operations acpi_device_fwnode_ops; 
extern const struct fwnode_operations acpi_data_fwnode_ops;

extern const struct fwnode_operations acpi_static_fwnode_ops;



bool is_acpi_device_node(const struct fwnode_handle *fwnode);

bool is_acpi_data_node(const struct fwnode_handle *fwnode);



static inline bool is_acpi_node(const struct fwnode_handle *fwnode)

{

	return !IS_ERR_OR_NULL(fwnode) &&

		(fwnode->ops == &acpi_device_fwnode_ops

		 || fwnode->ops == &acpi_data_fwnode_ops);

}



static inline bool is_acpi_device_node(const struct fwnode_handle *fwnode)

{

	return !IS_ERR_OR_NULL(fwnode) &&

		fwnode->ops == &acpi_device_fwnode_ops;

	return (is_acpi_device_node(fwnode) || is_acpi_data_node(fwnode));

}



#define to_acpi_device_node(__fwnode)					\
@@ -422,11 +417,6 @@ static inline bool is_acpi_device_node(const struct fwnode_handle *fwnode) 
			NULL;						\

	})



static inline bool is_acpi_data_node(const struct fwnode_handle *fwnode)

{

	return !IS_ERR_OR_NULL(fwnode) && fwnode->ops == &acpi_data_fwnode_ops;

}



#define to_acpi_data_node(__fwnode)					\

	({								\

		typeof(__fwnode) __to_acpi_data_node_fwnode = __fwnode;	\

CRA Git | Maintained and supported by SUSTech CRA and CCSE