Staging: rtl8192e: Revert one previous commit (c65a5a56) · Commits · 戴 / test

This patch reverts commit ("Staging: rtl8192e: Fix incorrect type in assignment in rtl819x_BAProc.c") as it is changing code and introducing bug to skip the endian conversion. Here, tmp variable is used to hold the endian-corrected values and network-data requires fixed endianness. Signed-off-by:

Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8192e/rtl819x_BAProc.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -115,14 +115,14 @@ static struct sk_buff rtllib_ADDBA(struct rtllib_device ieee, u8 *Dst,

		if (ACT_ADDBARSP == type) {
		RT_TRACE(COMP_DBG, "====>to send ADDBARSP\n");
		tmp = StatusCode;
		tmp = cpu_to_le16(StatusCode);
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;
		}
		tmp = pBA->BaParamSet.shortData;
		tmp = cpu_to_le16(pBA->BaParamSet.shortData);
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;
		tmp = pBA->BaTimeoutValue;
		tmp = cpu_to_le16(pBA->BaTimeoutValue);
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;

		@@ -178,10 +178,10 @@ static struct sk_buff rtllib_DELBA(struct rtllib_device ieee, u8 *dst,
		*tag++ = ACT_CAT_BA;
		*tag++ = ACT_DELBA;

		tmp = DelbaParamSet.shortData;
		tmp = cpu_to_le16(DelbaParamSet.shortData);
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;
		tmp = ReasonCode;
		tmp = cpu_to_le16(ReasonCode);
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;

Admin message