Commit c64550cf authored Oct 20, 2011 by Arnaldo Carvalho de Melo

perf hists: Don't decay total_period for filtered entries

Following the 'perf report' model we don't zap hist_entry instances from
the rb tree, we just keep them with he->filtered set to a mask of the
filters applied to it (thread, parent, DSO so far).

In top we need to decay even filtered entries, but we better not touch
total_period for them...

Now everything seems to work when filters are applied on top as they
worked in 'report', i.e. both dynamic and static hist entry browsing
works with filters.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-yt4xsbq20u9x9ypuwwyw2kao@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 2cf9cebf

tools/perf/util/hist.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -105,11 +105,16 @@ static void hist_entry__decay(struct hist_entry *he)

		static bool hists__decay_entry(struct hists hists, struct hist_entry he)
		{
		if (he->period == 0)
		u64 prev_period = he->period;

		if (prev_period == 0)
		return true;
		hists->stats.total_period -= he->period;

		hist_entry__decay(he);
		hists->stats.total_period += he->period;

		if (!he->filtered)
		hists->stats.total_period -= prev_period - he->period;

		return he->period == 0;
		}

Admin message