Commit c6384560 authored Jun 24, 2019 by Rasmus Villemoes Committed by Marc Kleine-Budde Jul 24, 2019

can: dev: call netif_carrier_off() in register_candev()

CONFIG_CAN_LEDS is deprecated. When trying to use the generic netdev
trigger as suggested, there's a small inconsistency with the link
property: The LED is on initially, stays on when the device is brought
up, and then turns off (as expected) when the device is brought down.

Make sure the LED always reflects the state of the CAN device.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent d86afb89

drivers/net/can/dev.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1249,6 +1249,8 @@ int register_candev(struct net_device *dev)
		return -EINVAL;

		dev->rtnl_link_ops = &can_link_ops;
		netif_carrier_off(dev);

		return register_netdev(dev);
		}
		EXPORT_SYMBOL_GPL(register_candev);

Admin message