Commit c62ae300 authored by David Disseldorp's avatar David Disseldorp Committed by Martin K. Petersen
Browse files

scsi: target: log NOP ping timeouts as errors 



Events resulting in connection outages like this should be logged as
errors. Include the I_T Nexus in the message to aid path identification.

Signed-off-by: default avatarDavid Disseldorp <ddiss@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d9a771fd

drivers/target/iscsi/iscsi_target_util.c

+5 −3
Original line number Diff line number Diff line
@@ -915,6 +915,7 @@ static int iscsit_add_nopin(struct iscsi_conn *conn, int want_response) 
void iscsit_handle_nopin_response_timeout(struct timer_list *t)

{

	struct iscsi_conn *conn = from_timer(conn, t, nopin_response_timer);

	struct iscsi_session *sess = conn->sess;



	iscsit_inc_conn_usage_count(conn);
@@ -925,9 +926,10 @@ void iscsit_handle_nopin_response_timeout(struct timer_list *t) 
		return;

	}



	pr_debug("Did not receive response to NOPIN on CID: %hu on"

		" SID: %u, failing connection.\n", conn->cid,

			conn->sess->sid);

	pr_err("Did not receive response to NOPIN on CID: %hu, failing"

		" connection for I_T Nexus %s,i,0x%6phN,%s,t,0x%02x\n",

		conn->cid, sess->sess_ops->InitiatorName, sess->isid,

		sess->tpg->tpg_tiqn->tiqn, (u32)sess->tpg->tpgt);

	conn->nopin_response_timer_flags &= ~ISCSI_TF_RUNNING;

	spin_unlock_bh(&conn->nopin_timer_lock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE