Commit c61a16a7 authored Nov 04, 2013 by Miao Xie Committed by Chris Mason Nov 11, 2013

Btrfs: fix the confusion between delalloc bytes and metadata bytes



In shrink_delalloc(), what we need reclaim is the metadata space, so
flushing pages by to_reclaim is not reasonable, it is very likely that
the pages we flush are not enough. And then we had to invoke the flush
function for several times, at the worst, we need call flush_space for
several times. It wasted time.

We improve this problem by converting the metadata space size we need
reserve to the delalloc bytes, By this way, we can flush the pages
by a reasonable number.

(Now we use a fixed number to do conversion, it is not flexible, maybe
 we can find a good way to improve it in the future.)

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>

parent 18cd8ea6

fs/btrfs/extent-tree.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -4034,6 +4034,8 @@ static inline int calc_reclaim_items_nr(struct btrfs_root *root, u64 to_reclaim)
		return nr;
		}

		#define EXTENT_SIZE_PER_ITEM (256 * 1024)

		/*
		* shrink metadata reservation for delalloc
		*/
		@@ -4050,6 +4052,10 @@ static void shrink_delalloc(struct btrfs_root *root, u64 to_reclaim, u64 orig,
		int loops;
		enum btrfs_reserve_flush_enum flush;

		/* Calc the number of the pages we need flush for space reservation */
		to_reclaim = calc_reclaim_items_nr(root, to_reclaim);
		to_reclaim *= EXTENT_SIZE_PER_ITEM;

		trans = (struct btrfs_trans_handle *)current->journal_info;
		block_rsv = &root->fs_info->delalloc_block_rsv;
		space_info = block_rsv->space_info;

Admin message