Commit c615dcb6 authored May 06, 2015 by Guido Martínez Committed by Dmitry Torokhov May 06, 2015

Input: adp5589-keys - fix event count mask



The event mask was specified as 0xF (4 bits) when in reality is 0x1F (5
bits) in order to be capable of representing all FIFO length values from
0 to 16.

This caused a problem: when the keypad reported 16 pending events the
driver took it as 0, and did nothing. This in turn caused the keypad to
re-issue the interrupt over and over again.

Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 195e610b

drivers/input/keyboard/adp5589-keys.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -180,7 +180,7 @@
		#define LOGIC2_STAT (1 << 7) /* ADP5589 only */
		#define LOGIC1_STAT (1 << 6)
		#define LOCK_STAT (1 << 5) /* ADP5589 only */
		#define KEC 0xF
		#define KEC 0x1F

		/* PIN_CONFIG_D Register */
		#define C4_EXTEND_CFG (1 << 6) /* RESET2 */

Admin message