Commit c5f3939b authored Jul 02, 2012 by Mark Brown

regulator: core: Support fixed voltages in regulator_is_supported_voltage()

Currently regulator_is_supported_voltage() works by enumerating the set
of voltages which can be set by the regulator but the checks we're doing
to impose constraints mean that if we can't vary the voltage we'll not
report any voltages as supported even though the regulator is actually
set at that voltage.

We could fix the voltage listing but this would mean that list_voltage()
could end up going to the hardware to get the current voltage which isn't
expected (it's supposed to be very cheap) so instead special case things
when we can't change the voltage and compare the requested range against
the current voltage.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 4fe23791

drivers/regulator/core.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -1890,8 +1890,18 @@ EXPORT_SYMBOL_GPL(regulator_list_voltage);
		int regulator_is_supported_voltage(struct regulator *regulator,
		int min_uV, int max_uV)
		{
		struct regulator_dev *rdev = regulator->rdev;
		int i, voltages, ret;

		/* If we can't change voltage check the current voltage */
		if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) {
		ret = regulator_get_voltage(regulator);
		if (ret >= 0)
		return (min_uV >= ret && ret <= max_uV);
		else
		return ret;
		}

		ret = regulator_count_voltages(regulator);
		if (ret < 0)
		return ret;

Admin message