Commit c5f06274 authored Oct 11, 2016 by Rob Herring Committed by Greg Kroah-Hartman Oct 31, 2016

driver core: skip removal test for non-removable drivers

Some drivers do not support removal/unbinding. These drivers should have
drv->suppress_bind_attrs set to true, so use that to skip the removal
test.

This doesn't fix anything reported so far, but should prevent some other
cases. Some drivers will need fixes to set suppress_bind_attrs to avoid
this test.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177021


Fixes: bea5b158 ("driver core: add test of driver remove calls during probe")
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a909d3e6

drivers/base/dd.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -324,7 +324,8 @@ static int really_probe(struct device dev, struct device_driver drv)
		{
		int ret = -EPROBE_DEFER;
		int local_trigger_count = atomic_read(&deferred_trigger_count);
		bool test_remove = IS_ENABLED(CONFIG_DEBUG_TEST_DRIVER_REMOVE);
		bool test_remove = IS_ENABLED(CONFIG_DEBUG_TEST_DRIVER_REMOVE) &&
		!drv->suppress_bind_attrs;

		if (defer_all_probes) {
		/*

Admin message