Commit c5ec874e authored Apr 30, 2020 by Ira Weiny Committed by Darrick J. Wong May 29, 2020

fs/xfs: Remove unnecessary initialization of i_rwsem



An earlier call of xfs_reinit_inode() from xfs_iget_cache_hit() already
handles initialization of i_rwsem.

Doing so again is unneeded.

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 2c567af4

fs/xfs/xfs_icache.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -423,6 +423,7 @@ xfs_iget_cache_hit(
		spin_unlock(&ip->i_flags_lock);
		rcu_read_unlock();

		ASSERT(!rwsem_is_locked(&inode->i_rwsem));
		error = xfs_reinit_inode(mp, inode);
		if (error) {
		bool wake;
		@@ -456,9 +457,6 @@ xfs_iget_cache_hit(
		ip->i_sick = 0;
		ip->i_checked = 0;

		ASSERT(!rwsem_is_locked(&inode->i_rwsem));
		init_rwsem(&inode->i_rwsem);

		spin_unlock(&ip->i_flags_lock);
		spin_unlock(&pag->pag_ici_lock);
		} else {

Admin message