Commit c5cbc78a authored Mar 08, 2019 by Nathan Chancellor Committed by Greg Kroah-Hartman Mar 19, 2019

tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup

When building with -Wsometimes-uninitialized, Clang warns:

drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud'
is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]

It's not wrong; when options is NULL, baud has no default value. Use
9600 as that is a sane default.

Link: https://github.com/ClangBuiltLinux/linux/issues/395


Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ac0cdb3d

drivers/tty/serial/qcom_geni_serial.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1050,7 +1050,7 @@ static int __init qcom_geni_console_setup(struct console co, char options)
		{
		struct uart_port *uport;
		struct qcom_geni_serial_port *port;
		int baud;
		int baud = 9600;
		int bits = 8;
		int parity = 'n';
		int flow = 'n';

Admin message