net: bridge: multicast: use rcu to access port list from br_multicast_start_querier (c5b493ce) · Commits · 戴 / test

br_multicast_start_querier() walks over the port list but it can be called from a timer with only multicast_lock held which doesn't protect the port list, so use RCU to walk over it. Fixes: ("bridge: Restart queries when last querier expires") Signed-off-by:

Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/bridge/br_multicast.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2031,7 +2031,8 @@ static void br_multicast_start_querier(struct net_bridge *br,

		__br_multicast_open(br, query);

		list_for_each_entry(port, &br->port_list, list) {
		rcu_read_lock();
		list_for_each_entry_rcu(port, &br->port_list, list) {
		if (port->state == BR_STATE_DISABLED \|\|
		port->state == BR_STATE_BLOCKING)
		continue;
		@@ -2043,6 +2044,7 @@ static void br_multicast_start_querier(struct net_bridge *br,
		br_multicast_enable(&port->ip6_own_query);
		#endif
		}
		rcu_read_unlock();
		}

		int br_multicast_toggle(struct net_bridge *br, unsigned long val)

Admin message