Commit c58cf4f1 authored Apr 26, 2012 by Ben Widawsky Committed by Daniel Vetter May 03, 2012

drm/i915: drop polled waits from i915_wait_request

The only time irq_get should fail is during unload or suspend. Both of
these points should try to quiesce the GPU before disabling interrupts
and so the atomic polling should never occur.

This was recommended by Chris Wilson as a way of reducing added
complexity to the polled wait which I introduced in an RFC patch.

09:57 < ickle_> it's only there as a fudge for waiting after irqs
after uninstalled during s&r, we aren't actually meant to hit it
09:57 < ickle_> so maybe we should just kill the code there and fix the breakage

v2: return -ENODEV instead of -EBUSY when irq_get fails

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

parent 9574b3fe

drivers/gpu/drm/i915/i915_gem.c

+11 −14

Original line number	Diff line number	Diff line
		@@ -1864,7 +1864,9 @@ i915_wait_request(struct intel_ring_buffer *ring,
		if (!i915_seqno_passed(ring->get_seqno(ring), seqno)) {
		trace_i915_gem_request_wait_begin(ring, seqno);

		if (ring->irq_get(ring)) {
		if (WARN_ON(!ring->irq_get(ring)))
		return -ENODEV;

		if (dev_priv->mm.interruptible)
		ret = wait_event_interruptible(ring->irq_queue,
		i915_seqno_passed(ring->get_seqno(ring), seqno)
		@@ -1875,11 +1877,6 @@ i915_wait_request(struct intel_ring_buffer *ring,
		\|\| atomic_read(&dev_priv->mm.wedged));

		ring->irq_put(ring);
		} else if (wait_for_atomic(i915_seqno_passed(ring->get_seqno(ring),
		seqno) \|\|
		atomic_read(&dev_priv->mm.wedged), 3000))
		ret = -EBUSY;

		trace_i915_gem_request_wait_end(ring, seqno);
		}
		if (atomic_read(&dev_priv->mm.wedged))

Admin message