Commit c577f4a5 authored Mar 30, 2019 by Colin Ian King Committed by Lorenzo Pieralisi Apr 15, 2019

PCI: rockchip: Fix rockchip_pcie_ep_assert_intx() bitwise operations



Currently the bitwise operations on the u16 variable 'status' with
the setting ROCKCHIP_PCIE_EP_CMD_STATUS_IS are incorrect because
ROCKCHIP_PCIE_EP_CMD_STATUS_IS is 1UL<<19 which is wider than the
u16 variable.

Fix this by making status a u32.

Fixes: cf590b07 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>

parent 9e98c678

drivers/pci/controller/pcie-rockchip-ep.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -350,7 +350,7 @@ static void rockchip_pcie_ep_assert_intx(struct rockchip_pcie_ep *ep, u8 fn,
		struct rockchip_pcie *rockchip = &ep->rockchip;
		u32 r = ep->max_regions - 1;
		u32 offset;
		u16 status;
		u32 status;
		u8 msg_code;

		if (unlikely(ep->irq_pci_addr != ROCKCHIP_PCIE_EP_PCI_LEGACY_IRQ_ADDR \|\|

Admin message