Commit c5563887 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: Use bitfield instead of bool for struct pci_vpd_pci22.busy 



Make struct pci_vpd_pci22.busy a 1-bit field instead of a bool.  We intend
to add another flag, and two bitfields are cheaper than two bools.

Tested-by: default avatarShane Seymour <shane.seymour@hpe.com>
Tested-by: default avatarBabu Moger <babu.moger@oracle.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
parent f52e5629

drivers/pci/access.c

+5 −5
Original line number Diff line number Diff line
@@ -283,8 +283,8 @@ struct pci_vpd_pci22 { 
	struct pci_vpd base;

	struct mutex lock;

	u16	flag;

	bool	busy;

	u8	cap;

	u8	busy:1;

};



/*
@@ -313,7 +313,7 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev) 
			return ret;



		if ((status & PCI_VPD_ADDR_F) == vpd->flag) {

			vpd->busy = false;

			vpd->busy = 0;

			return 0;

		}
@@ -355,7 +355,7 @@ static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count, 
						 pos & ~3);

		if (ret < 0)

			break;

		vpd->busy = true;

		vpd->busy = 1;

		vpd->flag = PCI_VPD_ADDR_F;

		ret = pci_vpd_pci22_wait(dev);

		if (ret < 0)
@@ -415,7 +415,7 @@ static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count 
		if (ret < 0)

			break;



		vpd->busy = true;

		vpd->busy = 1;

		vpd->flag = 0;

		ret = pci_vpd_pci22_wait(dev);

		if (ret < 0)
@@ -495,7 +495,7 @@ int pci_vpd_pci22_init(struct pci_dev *dev) 
		vpd->base.ops = &pci_vpd_pci22_ops;

	mutex_init(&vpd->lock);

	vpd->cap = cap;

	vpd->busy = false;

	vpd->busy = 0;

	dev->vpd = &vpd->base;

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE