Unverified Commit c553d290 authored May 25, 2020 by Dinghao Liu Committed by Mark Brown May 26, 2020

ASoC: ti: Fix runtime PM imbalance in omap2_mcbsp_set_clks_src



When clk_set_parent() returns an error code, a pairing
runtime PM usage counter increment is needed to keep the
counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200525085848.4227-1-dinghao.liu@zju.edu.cn


Signed-off-by: Mark Brown <broonie@kernel.org>

parent edc475be

sound/soc/ti/omap-mcbsp.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -77,18 +77,15 @@ static int omap2_mcbsp_set_clks_src(struct omap_mcbsp *mcbsp, u8 fck_src_id)
		pm_runtime_put_sync(mcbsp->dev);

		r = clk_set_parent(mcbsp->fclk, fck_src);
		if (r) {
		if (r)
		dev_err(mcbsp->dev, "CLKS: could not clk_set_parent() to %s\n",
		src);
		clk_put(fck_src);
		return r;
		}

		pm_runtime_get_sync(mcbsp->dev);

		clk_put(fck_src);

		return 0;
		return r;
		}

		static irqreturn_t omap_mcbsp_irq_handler(int irq, void *data)

Admin message