crypto: cavium/zip - Add missing single_release() (c552ffb5) · Commits · 戴 / test

When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. Fixes: ("crypto: zip - Add Compression/Decompression statistics") Cc: <stable@vger.kernel.org> Signed-off-by:

Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by:

Herbert Xu <herbert@gondor.apana.org.au>

drivers/crypto/cavium/zip/zip_main.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -593,6 +593,7 @@ static const struct file_operations zip_stats_fops = {
		.owner = THIS_MODULE,
		.open = zip_stats_open,
		.read = seq_read,
		.release = single_release,
		};

		static int zip_clear_open(struct inode inode, struct file file)
		@@ -604,6 +605,7 @@ static const struct file_operations zip_clear_fops = {
		.owner = THIS_MODULE,
		.open = zip_clear_open,
		.read = seq_read,
		.release = single_release,
		};

		static int zip_regs_open(struct inode inode, struct file file)
		@@ -615,6 +617,7 @@ static const struct file_operations zip_regs_fops = {
		.owner = THIS_MODULE,
		.open = zip_regs_open,
		.read = seq_read,
		.release = single_release,
		};

		/* Root directory for thunderx_zip debugfs entry */

Admin message